#500 Unify cartoon production status UI#509
Conversation
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #509 on the current live head. The change matches issue #500: cartoon production state is now derived from one shared status model and rendered compactly across Cuts, Publish, and Progress without the duplicate inline workflow panels competing for attention.
Findings
- No blocking findings.
Decision
Approved. buildCartoonProductionStatus now centralizes the post-upload workflow states used by Cuts, Publish, and Progress, FinishEpisodePanel reuses that shared surface instead of maintaining its own parallel step rendering, and Publish keeps cover/story-info readiness separate from the production flow while the full step map stays behind collapsed details. Live lint-and-typecheck was still pending at review time, so merge should still use the current live head/check state.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I reviewed PR #509 on live @Head 4f443f7c08a9e6454c0d987dc929d1f02682c255. The change matches issue #500 by moving Cuts, Publish, and Progress onto one shared production-status model and keeping detailed workflow guidance collapsed by default.
Findings
- No blocking findings.
Decision
Approved on GitHub. Cuts no longer has a separate default workflow strip plus finish-step panel, Publish shows the shared compact production status with publish-specific readiness pills, Progress uses the same active-step source, and live lint-and-typecheck passes.
2 participants
Summary
Add speech bubbles & captionsTesting
npm run typechecknpm run lint -- --quiet app/lib/cartoon-production-status.ts app/web/components/CartoonProductionStatus.tsx app/web/components/FinishEpisodePanel.tsx app/web/components/CutListPanel.tsx app/web/components/CartoonPublishPage.tsx app/web/components/StoryProgressPanel.tsx app/web/components/CartoonPublishPage.test.tsx app/web/components/StoryProgressPanel.test.tsx app/web/components/FinishEpisodePanel.test.tsxnpm run app:buildnpx vitest run --coverage.enabled=false app/web/components/FinishEpisodePanel.test.tsx app/web/components/StoryProgressPanel.test.tsx app/web/components/CartoonPublishPage.test.tsx(fails before collection in this environment withUnknown system error -122, write)Visual QA
1440x900: the cuts workspace opens with one compact workflow row and no second inline step strip, so the first cut stays above the fold while detailed production guidance remains insideWorkspace tools1728x1195: Progress, Cuts, and Publish all show the same active step badge/count source, and Publish keeps blocker/cover readiness visible without another full workflow stack in the default first screenRisks